Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for modular build structure. #850

Closed
wants to merge 22 commits into from
Closed

Add support for modular build structure. #850

wants to merge 22 commits into from

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024 •
edited
Loading

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@codecov Codecov
Copy link

codecov bot commented Aug 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (dcfe9df) to head (ea2ecb8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #850      +/-   ##
===========================================
- Coverage    99.21%   98.54%   -0.67%     
===========================================
  Files          157      157              
  Lines         8421     8407      -14     
===========================================
- Hits          8355     8285      -70     
- Misses          66      122      +56

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfe9df...ea2ecb8. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 15:29
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@alandefreitas
Copy link
Member

alandefreitas commented Aug 20, 2024 •
edited
Loading

I tried to rebase and squash it locally, but I had conflicts. Is it possible to do that (I don't know how automated this change is)? (I could apply the changes manually, but then the commit would be in my name)

Nevermind. I managed to do it in #860.

@alandefreitas alandefreitas mentioned this pull request Aug 20, 2024
Merged
alandefreitas
alandefreitas reviewed Aug 20, 2024
View reviewed changes
test/unit/Jamfile
@@ -52,7 +51,6 @@ local SOURCES =
segments_encoded_view.cpp
segments_ref.cpp
segments_view.cpp
snippets.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a merge misstep at some point in the past months.

test/unit/Jamfile
@@ -64,7 +62,6 @@ local SOURCES =
grammar/alnum_chars.cpp
grammar/alpha_chars.cpp
grammar/charset.cpp
grammar/ci_string.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.. Probably a merge misstep at some point in the past months.

@grafikrobot
Copy link
Member Author

I tried to rebase and squash it locally, but I had conflicts. Is it possible to do that (I don't know how automated this change is)? (I could apply the changes manually, but then the commit would be in my name)

Nevermind. I managed to do it in #860.

Doing a squash merge would have been easier.

@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://850.urlantora.prtest2.cppalliance.org/site/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://850.url.prtest2.cppalliance.org/libs/url/doc/html/index.html

@cppalliance-bot
Copy link

GCOVR code coverage report https://850.url.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://850.url.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff https://850.url.prtest2.cppalliance.org/gcovr/coverage_diff.txt

@alandefreitas
Copy link
Member

Rebased and merged as 471aec5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandefreitas alandefreitas alandefreitas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grafikrobot @cppalliance-bot @alandefreitas